Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various accessibility fixes. #2699

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Various accessibility fixes. #2699

wants to merge 5 commits into from

Conversation

ndarilek
Copy link

  • Add aria-label to Icon
  • Set tabIndex, role and aria-label on Button and IconButton
  • Set role and tabIndex on Link
  • Label bunches of unlabeled icon-only buttons.
  • Make login screen keyboard-navigable.
  • Make app logo keyboard-accessible.
  • Add alt attribute to SmartImage and set on cover images
  • Add navigation role to sidebar.

Marking as draft for now because I can't seem to get string values in place of their keys in en.json. Is there some i18n step not included in npm start or did I get something wrong?

Thanks.

* Add `aria-label` to `Icon`
* Set `tabIndex`, `role` and `aria-label` on `Button` and `IconButton`
* Set `role` and `tabIndex` on `Link`
* Label bunches of unlabeled icon-only buttons.
* Make login screen keyboard-navigable.
* Make app logo keyboard-accessible.
* Add `alt` attribute to `SmartImage` and set on cover images
* Add navigation role to sidebar.
@ndarilek ndarilek marked this pull request as ready for review August 27, 2021 12:56
@ndarilek
Copy link
Author

I think this one's ready, barring the issue of all strings appearing as their key rather than their value (I.e. "region.game" instead of "Game", which I asked about but couldn't get help with here, on Discord, or anywhere I looked in the docs.)

I'm a blind screen reader user and am about to release my third game on Itch. The app was already fairly usable, but these changes really make it pop, and I'd love to be able to recommend an even more accessible Itch app as the way to buy the game and keep it updated. Hoping to do more app work in the future--Steam is an accessibility dumpster fire with no signs of getting better, and while Itch can't compete in terms of some of Steam's addon platform services, I'd like to make it a no-brainer to recommend Itch for accessible game distribution.

Thanks!

@alts alts self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants